[tools] Always link weakly with NewsstandKit. Fixes #18606.#18621
[tools] Always link weakly with NewsstandKit. Fixes #18606.#18621rolfbjarne merged 1 commit intodotnet:mainfrom
Conversation
It seems that Apple will completely remove the NewsstandKit framework from iOS 17. This poses a problem for existing apps that link with NewsstandKit: they will crash at launch. Solve this by always linking weakly with the NewsstandKit framework; this way any apps that link with it will keep working if the framework ends up being removed by Apple. Fixes dotnet#18606.
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
✅ Generator diffGenerator diff is empty Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 235 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Probably we also need to backport this into xcode14.3 (legacy as well) |
|
/sudo backport release/7.0.3xx |
|
/sudo backport xcode14.3 |
|
Backport Job to branch xcode14.3 Created! The magic is happening here |
|
Backport Job to branch release/7.0.3xx Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8195370 for more details. |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8195369 for more details. |
…18606. (#18624) It seems that Apple will completely remove the NewsstandKit framework from iOS 17. This poses a problem for existing apps that link with NewsstandKit: they will crash at launch. Solve this by always linking weakly with the NewsstandKit framework; this way any apps that link with it will keep working if the framework ends up being removed by Apple. Fixes #18606. Fixes dotnet/maui#16316. Backport of #18621
… (#18625) It seems that Apple will completely remove the NewsstandKit framework from iOS 17. This poses a problem for existing apps that link with NewsstandKit: they will crash at launch. Solve this by always linking weakly with the NewsstandKit framework; this way any apps that link with it will keep working if the framework ends up being removed by Apple. Fixes #18606. Fixes dotnet/maui#16316. Backport of #18621
|
Is there any indication of when this will be released on VS for Mac now that iOS 17 is live? |
5 participants
It seems that Apple will completely remove the NewsstandKit framework from iOS 17.
This poses a problem for existing apps that link with NewsstandKit: they will
crash at launch.
Solve this by always linking weakly with the NewsstandKit framework; this way
any apps that link with it will keep working if the framework ends up being
removed by Apple.
Fixes #18606.
Fixes dotnet/maui#16316.